Output an appropriate warning when a cross info file does not exist. #2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If making a typo, it used to output: > Cross info file must have either host or a target machine. This was not useful at all and looked like there could be a file format error or some other issue with the content. Let's have an appropriate error: > File not found: /some/path
I got this warning on a build: > WARNING: Passed invalid keyword argument preset. This will become a hard error in the future. I had to grep in meson code to understand that "preset" was the name of the invalid argument. This is not obvious at all depending on the argument name (here it looked like it was about argument presets). Let's make it clearer by putting it in quotes.
|
I added another commit for a warning which was really not explicit either! |
Codecov Report
@@ Coverage Diff @@
## master #2021 +/- ##
=========================================
- Coverage 63.9% 63.9% -0.01%
=========================================
Files 71 71
Lines 17046 17051 +5
Branches 3506 3506
=========================================
+ Hits 10894 10897 +3
- Misses 5081 5083 +2
Partials 1071 1071
Continue to review full report at Codecov.
|
|
Great, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If making a typo, it used to output:
To show how confusing the old error was, I created the issue #2020 because I was just sure something was wrong with my file, while in fact meson was simply not reading my file because I had a typo in the command line (hyphen mistyped into underscore). It took me several dozens of minutes of searching the web for syntax issues, then even looking at meson code until I discovered the boring truth!
A "File not found" error will be far more obvious.